flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...
Date Fri, 03 Nov 2017 15:27:48 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r148808279
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -227,14 +241,27 @@ public void startNewWorker(ResourceProfile resourceProfile) {
     	}
     
     	@Override
    -	public boolean stopWorker(ResourceID resourceID) {
    -		// TODO: Implement to stop the worker
    -		return false;
    +	public boolean stopWorker(YarnWorkerNode workerNode) {
    +		workerNodeMap.remove(workerNode.getResourceID().toString());
    +		if (workerNode != null) {
    --- End diff --
    
    I think this should be checked first.


---

Mime
View raw message