flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #4939: [FLINK-4228][yarn/s3a] fix yarn resource upload s3...
Date Thu, 02 Nov 2017 20:57:15 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4939#discussion_r148656504
  
    --- Diff: flink-filesystems/flink-s3-fs-hadoop/pom.xml ---
    @@ -182,6 +182,21 @@ under the License.
     			<version>${project.version}</version>
     			<scope>test</scope>
     		</dependency>
    +		<!-- for HadoopS3FileSystemITCase.testRecursiveUploadForYarn -->
    --- End diff --
    
    Would be great if we can avoid adding these dependencies.
    This couples projects that were really meant to be independent, even if just in test scope.
    
    If this is about testing recursive upload, can this be written properly as a test case
in this project?
    Or can the Yarn upload test be completely in the yarn test project, adding a dependency
on this s3 project?


---

Mime
View raw message