flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4757: [FLINK-7694][REST][Webfrontend]Port JobMetricsHand...
Date Thu, 02 Nov 2017 17:48:24 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4757#discussion_r148609899
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobMetricsHandler.java
---
    @@ -32,8 +46,11 @@
      * The handler will then return a list containing the values of the requested metrics.
      * {@code [ { "id" : "X", "value" : "S" }, { "id" : "Y", "value" : "T" } ] }
      */
    -public class JobMetricsHandler extends AbstractMetricsHandler {
    +public class JobMetricsHandler extends AbstractMetricsHandler
    --- End diff --
    
    Why aren't we simply implementing a new handler? I think that we don't reuse any of `AbstractMetricsHandler`
functionality and, thus, there is no need to use it as a base class. 


---

Mime
View raw message