flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...
Date Thu, 02 Nov 2017 17:25:23 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4937#discussion_r148572112
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java
---
    @@ -294,11 +296,11 @@ public void returnAllocatedSlot(Slot slot) {
     		}
     	}
     
    -	private static ResourceManagerGateway createResourceManagerGatewayMock() {
    +	static ResourceManagerGateway createResourceManagerGatewayMock() {
     		ResourceManagerGateway resourceManagerGateway = mock(ResourceManagerGateway.class);
    --- End diff --
    
    We could think about implementing a `SimpleAckingResourceManagerGateway` for testing purposes.
That way we avoid mocking too much.


---

Mime
View raw message