flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bowenli86 <...@git.apache.org>
Subject [GitHub] flink issue #4932: [FLINK-7958][metrics] Allow reporters to define default d...
Date Wed, 01 Nov 2017 18:00:35 GMT
Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/4932
  
    I would suggest another solution - rather than adding another interface 'DelimiterProvider',
add `getDelimiter()` which returns '.' as an interface default method to `MetricReporter`.
Any reporter impl classes that don't override it will use the default delimiter.
    
    BTW, is it better to have `String getDelimiter()` rather than `char getDelimiter()`? Because
1) Flink has to convert char to string anyway 2) the former one provides more flexibility
in defining delimiters, e.g. as multi chars 


---

Mime
View raw message