flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under...
Date Wed, 01 Nov 2017 10:34:59 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4872#discussion_r148227334
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/UnregisteredTaskMetricsGroup.java
---
    @@ -28,15 +28,15 @@
     import org.apache.flink.runtime.metrics.groups.TaskManagerJobMetricGroup;
     import org.apache.flink.runtime.metrics.groups.TaskManagerMetricGroup;
     import org.apache.flink.runtime.metrics.groups.TaskMetricGroup;
    -import org.apache.flink.runtime.metrics.MetricRegistry;
    +import org.apache.flink.runtime.metrics.MetricRegistryImpl;
     import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
     import org.apache.flink.runtime.jobgraph.JobVertexID;
     
     import java.util.UUID;
     
     public class UnregisteredTaskMetricsGroup extends TaskMetricGroup {
     	
    -	private static final MetricRegistry EMPTY_REGISTRY = new MetricRegistry(MetricRegistryConfiguration.defaultMetricRegistryConfiguration());
    +	private static final MetricRegistryImpl EMPTY_REGISTRY = new MetricRegistryImpl(MetricRegistryConfiguration.defaultMetricRegistryConfiguration());
    --- End diff --
    
    good catch. Will change it.


---

Mime
View raw message