Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: Xpray <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
Message-ID: <git-pr-4829-flink@git.apache.org>
Subject: [GitHub] flink pull request #4829: [FLINK-7759][TableAPI & SQL] Fix Bug that fieldNam...
Content-Type: text/plain
Date: Mon, 16 Oct 2017 08:27:08 +0000 (UTC)
archived-at: Mon, 16 Oct 2017 08:27:12 -0000

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/4829

    [FLINK-7759][TableAPI & SQL] Fix Bug that fieldName with Boolean pref…

    Fix Bug that fieldName with Boolean prefix can't be parsed by ExpressionParser
    
    ## What is the purpose of the change
    
    Fix bug that field names with boolean prefix like "truex" or "FALSE_TARGET" can't be parsed by {{ExpressionParser}}
    
    
    ## Brief change log
    
    use `||| ` instead of ` | ` in `atom` parser, try to match as long as possible, and exchanging of positions of `fieldReference` parser and ` literalExpr ` parser is necessary, because `boolean` can be matched by both parsers, then it's captured by the latter one ` literalExpr ` .
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    StringExpressionTest.testFieldWithBooleanPrefix
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive):no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not documented
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-7759

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4829
    
----
commit 4cdfd18148a1a4e97e078bee6ccf4ba8c20c8034
Author: Xpray <leonxpray@gmail.com>
Date:   2017-10-16T08:13:26Z

    [FLINK-7759][TableAPI & SQL] Fix Bug that fieldName with Boolean prefix can't be parsed by ExpressionParser.

----


---