Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 31 Oct 2017 09:37:00 +0000 (UTC)
From: "Piotr Nowojski (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13112469.1509081455000.109376.1509442620127@Atlassian.JIRA>
In-Reply-To: <JIRA.13112469.1509081455000@Atlassian.JIRA>
References: <JIRA.13112469.1509081455000@Atlassian.JIRA> <JIRA.13112469.1509081455573@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (FLINK-7936) Lack of synchronization w.r.t.
 taskManagers in MetricStore#add()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 31 Oct 2017 09:37:05 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226511#comment-16226511 ] 

Piotr Nowojski edited comment on FLINK-7936 at 10/31/17 9:36 AM:
-----------------------------------------------------------------

{{computIfAbsent}} was not used before my refactor, so I guess this issue is only about the code after the refactor. However {{MetricStore#add()}} is only used internally and additionally (because of historical reasons) in tests. Internal usage is protected by lock on {{MetricStore.this}} in {{MetricStore#addAll()}}. Thus [~tedyu] I do not see where is this bug? 


was (Author: pnowojski):
{{computIfAbsent}} was not used before my refactor, so I guess this issue is only about the code after the refactor. However {{MetricStore#add()}} is only used internally and additionally (because of historical reasons) in tests. Internal usage is protected by lock on {{MetricStore.this}} in {{MetricStore#addAll()}}. Thus [~tedyu] I do not see where the bug is? 

> Lack of synchronization w.r.t. taskManagers in MetricStore#add()
> ----------------------------------------------------------------
>
>                 Key: FLINK-7936
>                 URL: https://issues.apache.org/jira/browse/FLINK-7936
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>           String tmID = ((QueryScopeInfo.TaskManagerQueryScopeInfo) info).taskManagerID;
>           tm = taskManagers.computeIfAbsent(tmID, k -> new TaskManagerMetricStore());
> {code}
> In other places, access to taskManagers is protected by lock on MetricStore.this


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)