Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Fri, 13 Oct 2017 08:40:02 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13109165.1507879313000.1515.1507884002591@Atlassian.JIRA>
In-Reply-To: <JIRA.13109165.1507879313000@Atlassian.JIRA>
References: <JIRA.13109165.1507879313000@Atlassian.JIRA> <JIRA.13109165.1507879313445@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7834) cost model (RelOptCost) extends
 network cost and memory cost
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 13 Oct 2017 08:40:12 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203196#comment-16203196 ] 

ASF GitHub Bot commented on FLINK-7834:
---------------------------------------

GitHub user godfreyhe opened a pull request:

    https://github.com/apache/flink/pull/4820

    [FLINK-7834] [table] cost model extends network cost and memory cost

    ## What is the purpose of the change
    
    *This pull request makes cost model (RelOptCost) extends network cost and memory cost*
    
    
    ## Brief change log
    
      - *The FlinkCost extends RelOptCost and adds network cost and memory cost*
      - *Updates DataSetCost*
      - *Adds getFlinkCostFactory method in TableEnvironment to get  specific FlinkCostFactory*
    
    
    ## Verifying this change
    
    This change is already covered by existing tests*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (JavaDocs)
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/godfreyhe/flink FLINK-7834

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4820
    
----
commit aea6c799391bfed62d27413c133eb1979040d188
Author: godfreyhe <godfreyhe@163.com>
Date:   2017-10-13T08:12:14Z

    [FLINK-7834] [table] cost model extends network cost and memory cost

----


> cost model (RelOptCost) extends network cost and memory cost
> ------------------------------------------------------------
>
>                 Key: FLINK-7834
>                 URL: https://issues.apache.org/jira/browse/FLINK-7834
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: godfrey he
>
> {{RelOptCost}} defines an interface for optimizer cost in terms of number of row processed, CPU cost, and I/O cost. Flink is a distributed framework, network and memory are also two important cost metrics which should be considered for optimizer. This feature is to extend RelOptCost.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)