Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 93EDB200D29 for ; Thu, 26 Oct 2017 16:06:53 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 92834160BF2; Thu, 26 Oct 2017 14:06:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D75521609E8 for ; Thu, 26 Oct 2017 16:06:52 +0200 (CEST) Received: (qmail 50200 invoked by uid 500); 26 Oct 2017 14:06:52 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 50190 invoked by uid 99); 26 Oct 2017 14:06:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Oct 2017 14:06:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 50B001A166D for ; Thu, 26 Oct 2017 14:06:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.02 X-Spam-Level: X-Spam-Status: No, score=-4.02 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id rwMAP2TMSOJX for ; Thu, 26 Oct 2017 14:06:50 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 36AB85FBF6 for ; Thu, 26 Oct 2017 14:06:50 +0000 (UTC) Received: (qmail 50181 invoked by uid 99); 26 Oct 2017 14:06:49 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Oct 2017 14:06:49 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A89E5DFB0E; Thu, 26 Oct 2017 14:06:49 +0000 (UTC) From: zentol To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4872: [FLINK-7876] Register TaskManagerMetricGroup under... Content-Type: text/plain Message-Id: <20171026140649.A89E5DFB0E@git1-us-west.apache.org> Date: Thu, 26 Oct 2017 14:06:49 +0000 (UTC) archived-at: Thu, 26 Oct 2017 14:06:53 -0000 Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4872#discussion_r147149524 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java --- @@ -239,7 +239,15 @@ public void shutdown() { if (queryService != null) { stopTimeout = new FiniteDuration(1L, TimeUnit.SECONDS); - stopFuture = Patterns.gracefulStop(queryService, stopTimeout); + + try { + stopFuture = Patterns.gracefulStop(queryService, stopTimeout); + } catch (IllegalStateException ignored) { + // this can happen if the underlying actor system has been stopped before shutting + // the metric registry down + // TODO: Pull the MetricQueryService actor out of the MetricRegistry + LOG.debug("Cannot gracefully stop the metric query service actor."); --- End diff -- include exception ---