Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: pnowojski <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4840-flink@git.apache.org>
In-Reply-To: <git-pr-4840-flink@git.apache.org>
Subject: [GitHub] flink pull request #4840: [FLINK-7368][metrics] Make MetricStore ThreadSafe ...
Content-Type: text/plain
Message-Id: <20171025130534.64163DFA0A@git1-us-west.apache.org>
Date: Wed, 25 Oct 2017 13:05:34 +0000 (UTC)
archived-at: Wed, 25 Oct 2017 13:05:39 -0000

GitHub user pnowojski reopened a pull request:

    https://github.com/apache/flink/pull/4840

    [FLINK-7368][metrics] Make MetricStore ThreadSafe class

    Remove external synchronisation on MetricStore
    
    ## What is the purpose of the change
    
    This is a refactor that makes `MetricStore` thread safe. It achieves it by pulling in all modifying methods and by returning immutable copies in getters.
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as `MetricStoreTest` or `MetricFetcherTest`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink flink7368

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4840.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4840
    
----
commit b19077430808923e047b808f68efd47f4c9527e0
Author: Piotr Nowojski <piotr.nowojski@gmail.com>
Date:   2017-10-16T14:53:14Z

    [FLINK-7368][metrics] Make MetricStore ThreadSafe class
    
    Remove external synchronization on MetricStore

commit b6be2ce229ec3c97cd3bc3861f1989e971599fd7
Author: Piotr Nowojski <piotr.nowojski@gmail.com>
Date:   2017-10-25T11:53:16Z

    fixup! [FLINK-7368][metrics] Make MetricStore ThreadSafe class

----


---