Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 90F1D200D20 for ; Tue, 17 Oct 2017 10:01:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8F8011609EB; Tue, 17 Oct 2017 08:01:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D50561609DE for ; Tue, 17 Oct 2017 10:01:25 +0200 (CEST) Received: (qmail 71070 invoked by uid 500); 17 Oct 2017 08:01:24 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 71061 invoked by uid 99); 17 Oct 2017 08:01:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 08:01:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 30FBD180781 for ; Tue, 17 Oct 2017 08:01:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id zo5XjDVtjF_9 for ; Tue, 17 Oct 2017 08:01:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 355555FB4E for ; Tue, 17 Oct 2017 08:01:21 +0000 (UTC) Received: (qmail 71025 invoked by uid 99); 17 Oct 2017 08:01:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 08:01:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6846FDF9C5; Tue, 17 Oct 2017 08:01:20 +0000 (UTC) From: suez1224 To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop... Content-Type: text/plain Message-Id: <20171017080120.6846FDF9C5@git1-us-west.apache.org> Date: Tue, 17 Oct 2017 08:01:20 +0000 (UTC) archived-at: Tue, 17 Oct 2017 08:01:26 -0000 Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145053774 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile resourceProfile) { } @Override - public void stopWorker(ResourceID resourceID) { - // TODO: Implement to stop the worker + public void stopWorker(YarnWorkerNode workerNode) { + workerNodeMap.remove(workerNode.getResourceID().toString()); --- End diff -- This API is only available from hadoop 2.6. Dont we need to support 2.3 and 2.4 as well? ---