Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3ED4B200D18 for ; Wed, 11 Oct 2017 18:10:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3D333160BE3; Wed, 11 Oct 2017 16:10:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8CCED1609CA for ; Wed, 11 Oct 2017 18:10:26 +0200 (CEST) Received: (qmail 90119 invoked by uid 500); 11 Oct 2017 16:10:25 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 90108 invoked by uid 99); 11 Oct 2017 16:10:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Oct 2017 16:10:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0F6F8C02A9 for ; Wed, 11 Oct 2017 16:10:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5cVoWUg1r58f for ; Wed, 11 Oct 2017 16:10:24 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 774FF5FCAE for ; Wed, 11 Oct 2017 16:10:23 +0000 (UTC) Received: (qmail 89638 invoked by uid 99); 11 Oct 2017 16:10:22 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Oct 2017 16:10:22 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2938EDFAB4; Wed, 11 Oct 2017 16:10:22 +0000 (UTC) From: pnowojski To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out... Content-Type: text/plain Message-Id: <20171011161022.2938EDFAB4@git1-us-west.apache.org> Date: Wed, 11 Oct 2017 16:10:22 +0000 (UTC) archived-at: Wed, 11 Oct 2017 16:10:27 -0000 Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r144025089 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -206,6 +209,53 @@ public void testCancelBeforeActive() throws Exception { client.cancelRequestFor(inputChannel.getInputChannelId()); } + /** + * Verifies that {@link RemoteInputChannel} is enqueued in the pipeline, and + * {@link AddCredit} message is sent to the producer. + */ + @Test + public void testNotifyCreditAvailable() throws Exception { + final CreditBasedClientHandler handler = new CreditBasedClientHandler(); + final EmbeddedChannel ch = new EmbeddedChannel(handler); --- End diff -- `ch` -> `channel` ---