Return-Path: <issues-return-134123-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 041F4200D26
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  5 Oct 2017 13:04:11 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 02B051609DA; Thu,  5 Oct 2017 11:04:11 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 59CA61609E1
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  5 Oct 2017 13:04:10 +0200 (CEST)
Received: (qmail 50509 invoked by uid 500); 5 Oct 2017 11:04:09 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 50364 invoked by uid 99); 5 Oct 2017 11:04:09 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2017 11:04:09 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C420F1A2E87
	for <issues@flink.apache.org>; Thu,  5 Oct 2017 11:04:08 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id kUKnGmCaNvvn for <issues@flink.apache.org>;
	Thu,  5 Oct 2017 11:04:08 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id C80BB5FD66
	for <issues@flink.incubator.apache.org>; Thu,  5 Oct 2017 11:04:07 +0000 (UTC)
Received: (qmail 49800 invoked by uid 99); 5 Oct 2017 11:04:07 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2017 11:04:07 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1B9E0F5B81; Thu,  5 Oct 2017 11:04:07 +0000 (UTC)
From: tillrohrmann <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4742-flink@git.apache.org>
In-Reply-To: <git-pr-4742-flink@git.apache.org>
Subject: [GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...
Content-Type: text/plain
Message-Id: <20171005110407.1B9E0F5B81@git1-us-west.apache.org>
Date: Thu,  5 Oct 2017 11:04:07 +0000 (UTC)
archived-at: Thu, 05 Oct 2017 11:04:11 -0000

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4742#discussion_r142897184
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java ---
    @@ -610,25 +633,15 @@ public void cancel(JobID jobId) throws Exception {
     	 *             failed. That might be due to an I/O problem, ie, the job-manager is unreachable.
     	 */
     	public void stop(final JobID jobId) throws Exception {
    -		final ActorGateway jobManagerGateway = getJobManagerGateway();
    +		final ActorGateway jobManager = getJobManagerGateway();
     
    -		final Future<Object> response;
    -		try {
    -			response = jobManagerGateway.ask(new JobManagerMessages.StopJob(jobId), timeout);
    -		} catch (final Exception e) {
    -			throw new ProgramInvocationException("Failed to query the job manager gateway.", e);
    -		}
    +		Future<Object> response = jobManager.ask(new JobManagerMessages.StopJob(jobId), timeout);
     
    -		final Object result = Await.result(response, timeout);
    +		final Object rc = Await.result(response, timeout);
     
    -		if (result instanceof JobManagerMessages.StoppingSuccess) {
    -			log.info("Job stopping with ID " + jobId + " succeeded.");
    -		} else if (result instanceof JobManagerMessages.StoppingFailure) {
    -			final Throwable t = ((JobManagerMessages.StoppingFailure) result).cause();
    -			log.info("Job stopping with ID " + jobId + " failed.", t);
    -			throw new Exception("Failed to stop the job because of \n" + t.getMessage());
    -		} else {
    -			throw new Exception("Unknown message received while stopping: " + result.getClass().getName());
    +		if (rc instanceof JobManagerMessages.StoppingFailure) {
    +			throw new Exception("Stopping the job with ID " + jobId + " failed.",
    +				((JobManagerMessages.StoppingFailure) rc).cause());
    --- End diff --
    
    The unknown response type exception was lost


---