flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7933) Test instability PrometheusReporterTest
Date Thu, 26 Oct 2017 17:11:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220811#comment-16220811

ASF GitHub Bot commented on FLINK-7933:

GitHub user zentol opened a pull request:


    [FLINK-7933][metrics] Improve PrometheusReporter tests

    ## What is the purpose of the change
    This PR resolves the test instabilities of the prometheus reporter.
    ## Brief change log
    * use a port range instead of a single hard-coded port
      * required the exposure of the bound port by the reporter
    * move registry/reporter initialization into an `@Before` method (guarantees execution
    * shutdown registry in `PrometheusReporterTest`
    ## Verifying this change
    This change is already covered by existing tests.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
    ## Documentation
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7933

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4908
commit 36168084423f704d8fb2647acf8dda2a09e4ee1d
Author: zentol <chesnay@apache.org>
Date:   2017-10-26T17:04:30Z

    [FLINK-7933][metrics] Improve PrometheusReporter tests


> Test instability PrometheusReporterTest
> ---------------------------------------
>                 Key: FLINK-7933
>                 URL: https://issues.apache.org/jira/browse/FLINK-7933
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics, Tests
>    Affects Versions: 1.4.0
>            Reporter: Kostas Kloudas
>            Assignee: Chesnay Schepler
>            Priority: Critical
>              Labels: test-stability
> Travis log: https://travis-ci.org/kl0u/flink/jobs/293220196

This message was sent by Atlassian JIRA

View raw message