flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ufuk Celebi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7916) Remove NetworkStackThroughputITCase
Date Wed, 25 Oct 2017 15:09:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218859#comment-16218859

Ufuk Celebi commented on FLINK-7916:

We also have {{flink-tests/src/test/java/org/apache/flink/test/state/ManualWindowSpeedITCase.java}}.
Agree that this is an anti-pattern and vote to either remove or establish a "benchmark" module.

> Remove NetworkStackThroughputITCase
> -----------------------------------
>                 Key: FLINK-7916
>                 URL: https://issues.apache.org/jira/browse/FLINK-7916
>             Project: Flink
>          Issue Type: Task
>          Components: Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>             Fix For: 1.5.0
> Flink's code base contains the {{NetworkStackThroughputITCase}} which is not really a
test. Moreover it is marked as {{Ignored}}. I propose to remove this test because it is more
of a benchmark. We could think about creating a benchmark project where we move these kind
of "tests".
> In general I think we should remove ignored tests if they won't be fixed immediately.
The danger is far too high that we forget about them and then we only keep the maintenance
burden of it. This is especially true for the above mentioned test case.

This message was sent by Atlassian JIRA

View raw message