flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7908) Restructure the QS module to reduce client deps.
Date Wed, 25 Oct 2017 16:53:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219054#comment-16219054
] 

ASF GitHub Bot commented on FLINK-7908:
---------------------------------------

GitHub user kl0u opened a pull request:

    https://github.com/apache/flink/pull/4906

    [FLINK-7908][FLINK-7824][QS] Restructure QS packages and put QS jars in opt/.

    ## What is the purpose of the change
    
    Make the Queryable State more usable by:
    1) Reducing the dependencies the `client` jar (used by the user) transitively brings.
    2) Putting the core and client jars in the `opt/` folder. From there, to activate QS the
user has to put the core jar in the lib/ folder before starting the cluster, and use the client
jar as a dependency to his/her program.
    
    ## Brief change log
    
    Creating the `core` and `client` modules in the queryable state dir and moving classes
around.
    In addition, now the `client` module becomes a dependency of the `flink-runtime`.
    
    Places the jars corresponding the aforementioned modules to the `opt` dir.
    
    ## Verifying this change
    
    This change is a simple restructuring of the queryable state module, no classes are introduced
or deleted.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): yes, adds the `flink-queryable-state-client`
dependency to `flink-runtime`.
    
    ## Documentation
    
      - Does this pull request introduce a new feature? NO, but it needs documentation, which
is PENDING.
    
    R @aljoscha 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kl0u/flink qs-restructure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4906.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4906
    
----
commit 057f14d833e56fa731262384a636af13f08623d5
Author: kkloudas <kkloudas@gmail.com>
Date:   2017-10-24T10:16:08Z

    [FLINK-7908][QS] Restructure the queryable state module.
    
    The QS module is split into core and client. The core should
    be put in the lib folder to enable queryable state, while the
    client is the one that the user will program against. The
    reason for the restructuring in mainly to remove the dependency
    on the flink-runtime from the user's program.

commit dc9d5964bcdd3269fe01e8fe2ab7be74d90dd22c
Author: kkloudas <kkloudas@gmail.com>
Date:   2017-10-24T14:12:27Z

    [FLINK-7824][QS] Put the QS modules in the opt folder.
    
    Now the user can find the jars in the opt/ folder and
    he can activate QS by putting the core jar in the lib/
    folder and program against the client jar.

----


> Restructure the QS module to reduce client deps.
> ------------------------------------------------
>
>                 Key: FLINK-7908
>                 URL: https://issues.apache.org/jira/browse/FLINK-7908
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Queryable State
>    Affects Versions: 1.4.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message