flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7854) Reject lateral table outer joins with predicates in SQL
Date Tue, 17 Oct 2017 22:52:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208537#comment-16208537
] 

ASF GitHub Bot commented on FLINK-7854:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4846#discussion_r145268283
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CorrelateTest.scala
---
    @@ -75,20 +76,29 @@ class CorrelateTest extends TableTestBase {
         util.verifySql(sqlQuery2, expected2)
       }
     
    -  @Test
    -  def testLeftOuterJoin(): Unit = {
    +  /**
    +    * Due to the temporary restriction on lateral table outer join (see FLINK-7854),
this test can
    +    * not be normally passed now. In the future, the left local predicates should be
pushed down.
    +    */
    +  @Test (expected = classOf[ValidationException])
    +  def testLeftOuterJoinWithLeftLocalPredicates(): Unit = {
         val util = streamTestUtil()
         val func1 = new TableFunc1
         util.addTable[(Int, Long, String)]("MyTable", 'a, 'b, 'c)
         util.addFunction("func1", func1)
     
    -    val sqlQuery = "SELECT c, s FROM MyTable LEFT JOIN LATERAL TABLE(func1(c)) AS T(s)
ON TRUE"
    --- End diff --
    
    Keep the previous test and add the new test to `validation.CorrelateValidationTest`


> Reject lateral table outer joins with predicates in SQL
> -------------------------------------------------------
>
>                 Key: FLINK-7854
>                 URL: https://issues.apache.org/jira/browse/FLINK-7854
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Xingcan Cui
>            Assignee: Xingcan Cui
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> Due to CALCITE-2004, lateral table outer joins can not be normally executed. We should
cover it up by rejecting join predicates temporarily, until the issue is fixed in Calcite.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message