flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7813) Replace MetricRegistryThreadFactory
Date Wed, 11 Oct 2017 13:17:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200252#comment-16200252
] 

ASF GitHub Bot commented on FLINK-7813:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4803

    [FLINK-7813] [metrics] Replace MetricRegistryThreadFactory

    ## What is the purpose of the change
    
    This PR modifies the MetricRegistry to use the ExecutorThreadFactory instead of its own
MetricRegistrThreadFactory. The implementations are virtually identical, so this primarily
serves
    code-deduplication.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7813

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4803.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4803
    
----
commit 3bdebd26a25012410c702994a0f92716cbca0d93
Author: zentol <chesnay@apache.org>
Date:   2017-10-11T13:13:00Z

    [FLINK-7813] [metrics] Replace MetricRegistryThreadFactory

----


> Replace MetricRegistryThreadFactory
> -----------------------------------
>
>                 Key: FLINK-7813
>                 URL: https://issues.apache.org/jira/browse/FLINK-7813
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> The MetricRegistry uses a custom ThreadFactory implementation to give threads names,
whereas we could use the Flinks ExecutorThreadFactory instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message