flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7791) Integrate LIST command into REST client
Date Wed, 11 Oct 2017 13:32:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200273#comment-16200273
] 

ASF GitHub Bot commented on FLINK-7791:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4802#discussion_r144011359
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
    @@ -192,6 +196,18 @@ public String cancelWithSavepoint(JobID jobId, @Nullable String savepointDirecto
     			.thenApply(response -> response.location);
     	}
     
    +	@Override
    +	public CompletableFuture<Collection<JobDetails>> listJobs() throws Exception
{
    +		CurrentJobsOverviewHandlerHeaders headers = CurrentJobsOverviewHandlerHeaders.getInstance();
    +		CompletableFuture<MultipleJobsDetails> jobDetailsFuture = restClient.sendRequest(
    +			restClusterClientConfiguration.getRestServerAddress(),
    +			restClusterClientConfiguration.getRestServerPort(),
    +			headers
    +		);
    +		return jobDetailsFuture
    +			.thenApply(MultipleJobsDetails::getRunning);
    --- End diff --
    
    we don't _have_ to, as the LIST command only cares about running jobs, but we certainly
could just return all. The CLI is filtering the jobs anyway.


> Integrate LIST command into REST client
> ---------------------------------------
>
>                 Key: FLINK-7791
>                 URL: https://issues.apache.org/jira/browse/FLINK-7791
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client, REST
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message