flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7423) Always reuse an instance to get elements from the inputFormat
Date Wed, 11 Oct 2017 02:33:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199716#comment-16199716
] 

ASF GitHub Bot commented on FLINK-7423:
---------------------------------------

Github user XuPingyong closed the pull request at:

    https://github.com/apache/flink/pull/4525


> Always reuse an instance  to get elements from the inputFormat 
> ---------------------------------------------------------------
>
>                 Key: FLINK-7423
>                 URL: https://issues.apache.org/jira/browse/FLINK-7423
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>            Reporter: Xu Pingyong
>            Assignee: Xu Pingyong
>
> In InputFormatSourceFunction.java:
> {code:java}
> OUT nextElement = serializer.createInstance();
> 			while (isRunning) {
> 				format.open(splitIterator.next());
> 				// for each element we also check if cancel
> 				// was called by checking the isRunning flag
> 				while (isRunning && !format.reachedEnd()) {
> 					nextElement = format.nextRecord(nextElement);
> 					if (nextElement != null) {
> 						ctx.collect(nextElement);
> 					} else {
> 						break;
> 					}
> 				}
> 				format.close();
> 				completedSplitsCounter.inc();
> 				if (isRunning) {
> 					isRunning = splitIterator.hasNext();
> 				}
> 			}
> {code}
> the format may return other element or null when nextRecord, that will may cause exception.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message