flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based
Date Mon, 02 Oct 2017 14:34:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188181#comment-16188181

ASF GitHub Bot commented on FLINK-7406:

Github user zhijiangW commented on the issue:

    @NicoK , I have fixed the other code issues. 
    For UT, I only added one test for verifying  there is no race condition between requesting
and recycling floating buffers. I am not sure whether to control the process by `CountDownLatch`
is enough. Or I should submit two different threads to execute the process repeated. If this
way is ok, I will add more tests for race condition along with `NetworkBufferPool#createBufferPool()`
modifications you suggested. 
    For fair distribution of buffers test, I will add one test, maybe in this PR or in #4735

> Implement Netty receiver incoming pipeline for credit-based
> -----------------------------------------------------------
>                 Key: FLINK-7406
>                 URL: https://issues.apache.org/jira/browse/FLINK-7406
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.4.0
> This is a part of work for credit-based network flow control.
> Currently {{PartitionRequestClientHandler}} receives and reads {{BufferResponse}} from
producer. It will request buffer from {{BufferPool}} for holding the message. If not got,
the message is staged temporarily and {{autoread}} for channel is set false.
> For credit-based mode, {{PartitionRequestClientHandler}} can always get buffer from {{RemoteInputChannel}}
for reading messages from producer.
> The related works are:
> * Add the backlog of producer in {{BufferResponse}} message structure
> * {{PartitionRequestClientHandler}} requests buffer from {{RemoteInputChannel}} directly
> * {{PartitionRequestClientHandler}} updates backlog for {{RemoteInputChannel}}, and it
may trigger requests of floating buffers from {{BufferPool}}

This message was sent by Atlassian JIRA

View raw message