flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling
Date Wed, 18 Oct 2017 06:31:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208868#comment-16208868

ASF GitHub Bot commented on FLINK-7076:

Github user suez1224 commented on a diff in the pull request:

    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile resourceProfile) {
    -	public void stopWorker(ResourceID resourceID) {
    -		// TODO: Implement to stop the worker
    +	public void stopWorker(YarnWorkerNode workerNode) {
    +		workerNodeMap.remove(workerNode.getResourceID().toString());
    --- End diff --
    Since we will need to keep workerNodeMap anyway, we can actually just look up the containerId
using resourceId from workerNodeMap, there is no need to calculate the containerId from resourceId,
so I think we dont need to use ContainerId.fromString. Also, copying the code will have compatibility
issue if the fromString method differ in different hadoop version. What do you think?

> Implement container release to support dynamic scaling
> ------------------------------------------------------
>                 Key: FLINK-7076
>                 URL: https://issues.apache.org/jira/browse/FLINK-7076
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>            Reporter: Till Rohrmann
>            Assignee: Shuyi Chen
>              Labels: flip-6
> In order to support dynamic scaling, the {{YarnResourceManager}} has to be able to dynamically
free containers. We have to implement the {{YarnResourceManager#stopWorker}} method.

This message was sent by Atlassian JIRA

View raw message