flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint
Date Mon, 02 Oct 2017 12:16:08 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187954#comment-16187954
] 

ASF GitHub Bot commented on FLINK-7072:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4742#discussion_r142121549
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/BlobServerPortHandlerTest.java
---
    @@ -0,0 +1,65 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler.job;
    +
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.runtime.dispatcher.DispatcherGateway;
    +import org.apache.flink.runtime.rest.handler.HandlerRequest;
    +import org.apache.flink.runtime.rest.messages.BlobServerPortResponseBody;
    +import org.apache.flink.runtime.rest.messages.EmptyMessageParameters;
    +import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
    +import org.apache.flink.runtime.rpc.RpcUtils;
    +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever;
    +
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.util.concurrent.CompletableFuture;
    +
    +import static org.mockito.Matchers.any;
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.when;
    +
    +/**
    + * Tests for the {@link BlobServerPortHandler}.
    + */
    +public class BlobServerPortHandlerTest {
    +	private static final int PORT = 64;
    +
    +	@Test
    +	public void testPortRetrieval() throws Exception {
    +		DispatcherGateway mockGateway = mock(DispatcherGateway.class);
    +		when(mockGateway.getBlobServerPort(any(Time.class))).thenReturn(CompletableFuture.completedFuture(PORT));
    +		GatewayRetriever<DispatcherGateway> mockGatewayRetriever = mock(GatewayRetriever.class);
    +
    +		BlobServerPortHandler handler = new BlobServerPortHandler(
    +			CompletableFuture.completedFuture("http://localhost:1234"),
    +			mockGatewayRetriever,
    +			RpcUtils.INF_TIMEOUT);
    +
    +		BlobServerPortResponseBody portResponse = handler.handleRequest(new HandlerRequest<>(EmptyRequestBody.getInstance(),
EmptyMessageParameters.getInstance()), mockGateway).get();
    +
    +		Assert.assertEquals(PORT, portResponse.port);
    +	}
    +
    +	@Test
    +	public void testPortRetrievalFailureHandling() throws Exception {
    +
    +	}
    --- End diff --
    
    Forgotten to implement?


> Create RESTful cluster endpoint
> -------------------------------
>
>                 Key: FLINK-7072
>                 URL: https://issues.apache.org/jira/browse/FLINK-7072
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Chesnay Schepler
>              Labels: flip-6
>             Fix For: 1.4.0
>
>
> In order to communicate with the cluster from the RESTful client, we have to implement
a RESTful cluster endpoint. The endpoint shall support the following operations:
> * List jobs (GET): Get list of all running jobs on the cluster
> * Submit job (POST): Submit a job to the cluster (only supported in session mode)
> * Get job status (GET): Get the status of an executed job (and maybe the JobExecutionResult)
> * Lookup job leader (GET): Gets the JM leader for the given job
> This endpoint will run in session mode alongside the dispatcher/session runner and forward
calls to this component which maintains a view on all currently executed jobs.
> In the per-job mode, the endpoint will return only the single running job and the address
of the JobManager alongside which it is running. Furthermore, it won't accept job submissions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message