flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint
Date Mon, 02 Oct 2017 12:16:08 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187947#comment-16187947
] 

ASF GitHub Bot commented on FLINK-7072:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4742#discussion_r142120781
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java
---
    @@ -0,0 +1,66 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler.job;
    +
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.runtime.concurrent.FutureUtils;
    +import org.apache.flink.runtime.dispatcher.DispatcherGateway;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.runtime.rest.handler.AbstractRestHandler;
    +import org.apache.flink.runtime.rest.handler.HandlerRequest;
    +import org.apache.flink.runtime.rest.handler.RestHandlerException;
    +import org.apache.flink.runtime.rest.messages.EmptyMessageParameters;
    +import org.apache.flink.runtime.rest.messages.job.JobSubmitHeaders;
    +import org.apache.flink.runtime.rest.messages.job.JobSubmitRequestBody;
    +import org.apache.flink.runtime.rest.messages.job.JobSubmitResponseBody;
    +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever;
    +
    +import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
    +
    +import javax.annotation.Nonnull;
    +
    +import java.io.ByteArrayInputStream;
    +import java.io.ObjectInputStream;
    +import java.util.concurrent.CompletableFuture;
    +
    +/**
    + * This handler can be used to submit jobs to a Flink cluster.
    + */
    +public final class JobSubmitHandler extends AbstractRestHandler<DispatcherGateway,
JobSubmitRequestBody, JobSubmitResponseBody, EmptyMessageParameters> {
    +
    +	public JobSubmitHandler(CompletableFuture<String> localRestAddress, GatewayRetriever<DispatcherGateway>
leaderRetriever, Time timeout) {
    +		super(localRestAddress, leaderRetriever, timeout, JobSubmitHeaders.getInstance());
    +	}
    +
    +	@Override
    +	protected CompletableFuture<JobSubmitResponseBody> handleRequest(@Nonnull HandlerRequest<JobSubmitRequestBody,
EmptyMessageParameters> request, @Nonnull DispatcherGateway gateway) throws RestHandlerException
{
    +		JobGraph jobGraph;
    +		try {
    +			ObjectInputStream objectIn = new ObjectInputStream(new ByteArrayInputStream(request.getRequestBody().serializedJobGraph));
    +			jobGraph = (JobGraph) objectIn.readObject();
    --- End diff --
    
    Here we are doing unnecessary work by deserializing the `JobGraph`. It would be best if
we could simply forward the serialized `JobGraph` to the `Dispatcher`. Maybe we could have
a wrapper which lazily deserializes the `JobGraph` on the `Dispatcher`?


> Create RESTful cluster endpoint
> -------------------------------
>
>                 Key: FLINK-7072
>                 URL: https://issues.apache.org/jira/browse/FLINK-7072
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Chesnay Schepler
>              Labels: flip-6
>             Fix For: 1.4.0
>
>
> In order to communicate with the cluster from the RESTful client, we have to implement
a RESTful cluster endpoint. The endpoint shall support the following operations:
> * List jobs (GET): Get list of all running jobs on the cluster
> * Submit job (POST): Submit a job to the cluster (only supported in session mode)
> * Get job status (GET): Get the status of an executed job (and maybe the JobExecutionResult)
> * Lookup job leader (GET): Gets the JM leader for the given job
> This endpoint will run in session mode alongside the dispatcher/session runner and forward
calls to this component which maintains a view on all currently executed jobs.
> In the per-job mode, the endpoint will return only the single running job and the address
of the JobManager alongside which it is running. Furthermore, it won't accept job submissions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message