flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5968) Document WindowedStream.aggregate()
Date Thu, 19 Oct 2017 15:18:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211188#comment-16211188
] 

ASF GitHub Bot commented on FLINK-5968:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4833#discussion_r145731146
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
    @@ -67,7 +67,7 @@ abstract class GeneratedAggregations extends Function {
         *                     aggregated results
         * @param input        input values bundled in a row
    --- End diff --
    
    Please change `retract()` accordingly to keep the interfaces consistent.
    
    Alternatively, you can also revert the changes on `GeneratedAggregations` which is only
an internal interface. The Table API `org.apache.flink.table.functions.AggregateFunction`
does not support immutable accumulators, so this change has no effect until the public interface
is changed. If you revert, we only need to touch `AggregateAggFunction` and not the code generator.


> Document WindowedStream.aggregate()
> -----------------------------------
>
>                 Key: FLINK-5968
>                 URL: https://issues.apache.org/jira/browse/FLINK-5968
>             Project: Flink
>          Issue Type: Sub-task
>          Components: DataStream API, Documentation
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message