flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
Date Thu, 26 Oct 2017 12:09:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220358#comment-16220358
] 

ASF GitHub Bot commented on FLINK-5823:
---------------------------------------

Github user bowenli86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4907#discussion_r147121427
  
    --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
    @@ -243,11 +245,19 @@ else if (directory.exists()) {
     	 * @throws IOException if the delete operation fails
     	 */
     	public static boolean deletePathIfEmpty(FileSystem fileSystem, Path path) throws IOException
{
    -		FileStatus[] fileStatuses = null;
    +		final FileStatus[] fileStatuses;
     
     		try {
     			fileStatuses = fileSystem.listStatus(path);
    -		} catch (Exception ignored) {}
    +		}
    +		catch (FileNotFoundException e) {
    +			// path already deleted
    +			return true;
    +		}
    +		catch (Exception e) {
    +			// could not access directory, cannot delete
    --- End diff --
    
    Make sense. Thanks for the explanation!


> Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
> -----------------------------------------------------------------------
>
>                 Key: FLINK-5823
>                 URL: https://issues.apache.org/jira/browse/FLINK-5823
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Blocker
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message