flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4915: [FLINK-7838] Bunch of hotfixes and fix missing syn...
Date Tue, 31 Oct 2017 10:10:46 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4915#discussion_r147942486
  
    --- Diff: flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
    @@ -61,7 +61,7 @@
      * IT cases for the {@link FlinkKafkaProducer011}.
      */
     @SuppressWarnings("serial")
    -public class FlinkKafkaProducer011Tests extends KafkaTestBase {
    +public class FlinkKafkaProducer011Test extends KafkaTestBase {
    --- End diff --
    
    Aren't all of the other `ITCase`s starting a Flink job? 
    
    Regardless I named it `Test` originally because it is slightly more unit "testish" compared
to `Kafka011ProducerExactlyOnceITCase`.


---

Mime
View raw message