flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...
Date Fri, 27 Oct 2017 06:38:24 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4894#discussion_r146576347
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableSchema.scala
---
    @@ -50,6 +50,11 @@ class TableSchema(
     
       val columnNameToIndex: Map[String, Int] = columnNames.zipWithIndex.toMap
     
    +  /** Returns a copy of the TableSchema */
    +  def copy: TableSchema = {
    --- End diff --
    
    Maybe mention the deep copy behavior.


---

Mime
View raw message