flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yew1eb <...@git.apache.org>
Subject [GitHub] flink pull request #4869: [FLINK-7843][docs] Improve documentation for metri...
Date Thu, 26 Oct 2017 09:38:27 GMT
Github user yew1eb commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4869#discussion_r147091360
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -801,53 +849,67 @@ Thus, in order to infer the metric identifier:
     <table class="table table-bordered">
       <thead>
         <tr>
    -      <th class="text-left" style="width: 20%">Scope</th>
    -      <th class="text-left" style="width: 30%">Metrics</th>
    -      <th class="text-left" style="width: 50%">Description</th>
    +      <th class="text-left" style="width: 18%">Scope</th>
    +      <th class="text-left" style="width: 26%">Metrics</th>
    +      <th class="text-left" style="width: 48%">Description</th>
    +      <th class="text-left" style="width: 8%">Type</th>
         </tr>
       </thead>
       <tbody>
         <tr>
           <th rowspan="9"><strong>Job (only available on JobManager)</strong></th>
           <td>lastCheckpointDuration</td>
    -      <td>The time it took to complete the last checkpoint.</td>
    +      <td>The time it took to complete the last checkpoint (in milliseconds).</td>
    +      <td>Gauge</td>
         </tr>
         <tr>
           <td>lastCheckpointSize</td>
    -      <td>The total size of the last checkpoint.</td>
    +      <td>The total size of the last checkpoint (in bytes).</td>
    +      <td>Gauge</td>
         </tr>
         <tr>
           <td>lastCheckpointExternalPath</td>
           <td>The path where the last external checkpoint was stored.</td>
    +      <td>Gauge</td>
         </tr>
         <tr>
           <td>lastCheckpointRestoreTimestamp</td>
    -      <td>Timestamp when the last checkpoint was restored at the coordinator.</td>
    +      <td>Timestamp when the last checkpoint was restored at the coordinator (in
milliseconds).</td>
    --- End diff --
    
    Yes.
    but the "milliseconds" not cause confusion to the users. 


---

Mime
View raw message