flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #4879: [FLINK-7783] Don't always remove checkpoints in Zo...
Date Mon, 23 Oct 2017 09:58:49 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4879#discussion_r146218235
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
    @@ -302,4 +302,32 @@ public void registerSharedStatesAfterRestored(SharedStateRegistry
sharedStateReg
     	public String toString() {
     		return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
     	}
    +
    +	@Override
    +	public boolean equals(Object o) {
    +		if (this == o) {
    +			return true;
    +		}
    +		if (o == null || getClass() != o.getClass()) {
    +			return false;
    +		}
    +
    +		CompletedCheckpoint that = (CompletedCheckpoint) o;
    +
    +		if (checkpointID != that.checkpointID) {
    +			return false;
    +		}
    +		if (timestamp != that.timestamp) {
    --- End diff --
    
    It should be, so fixing.


---

Mime
View raw message