flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....
Date Thu, 19 Oct 2017 15:17:11 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4833#discussion_r145726822
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala
---
    @@ -52,7 +52,7 @@ import org.apache.flink.table.dataview.MapViewTypeInfoFactory
       *      return accum;
       *    }
       *
    -  *    public void accumulate(MyAccum accumulator, String id) {
    +  *    public MyAccum accumulate(MyAccum accumulator, String id) {
    --- End diff --
    
    Please revert these changes.
    The `accumulate` method belongs to a Table API `org.apache.flink.table.functions.AggregateFunction`
and not `GeneratedAggregations`.


---

Mime
View raw message