flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...
Date Thu, 19 Oct 2017 12:54:06 GMT
Github user GJL commented on the issue:

    Thanks for your contribution. I have a few questions because the submitted code does not
match with what the ticket currently says:
    From https://issues.apache.org/jira/browse/FLINK-5486:
    >The handlePendingFilesForPreviousCheckpoints() call should be enclosed inside the
synchronization block. Otherwise during the processing of handlePendingFilesForPreviousCheckpoints(),
some entries of the map may be cleared.
    I am confused because the submitted code encloses `bucketState.pendingFilesPerCheckpoint.clear();`
in a synchronized block.
    @tedyu Did you run into actual production issues, or did you find the problem while reviewing
the code? Can you elaborate why the additional synchronized block is needed? 


View raw message