flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink issue #4705: [FLINK-6444] [build] Add a check that '@VisibleForTesting...
Date Thu, 19 Oct 2017 09:57:57 GMT
Github user pnowojski commented on the issue:

    Hmmm, I looked a little bit and it seems like there are tools doing this:
    It evens seems to be working based on 
     * <p>A detector to ensure that implementation (class in src/main/java) doesn't
     * package-private method in other class which is annotated by {@code @VisibleForTesting}.
    If above doesn't work/fit us, we could probably easily implement our own check for that
using [findbugs-maven-plugin](https://gleclaire.github.io/findbugs-maven-plugin/usage.html),
maybe like described [here](https://writeoncereadmany.wordpress.com/2016/04/08/how-to-find-bugs-part-3-visiblefortesting/).
    Nevertheless I think this feature should be first discussed on a dev mailing list. I am
not against it (as long as it will not significantly prolong builds), but it would be better
to discuss this with the community. 


View raw message