flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...
Date Tue, 17 Oct 2017 12:39:04 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4826#discussion_r145113966
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogram.java
---
    @@ -0,0 +1,51 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.util.latency;
    +
    +import org.apache.flink.metrics.Histogram;
    +import org.apache.flink.metrics.HistogramStatistics;
    +
    +import org.apache.commons.math3.stat.descriptive.DescriptiveStatistics;
    +
    +/**
    + * The {@link LatencyHistogram} use a DescriptiveStatistics {@link DescriptiveStatistics}
as a Flink {@link Histogram}.
    + */
    +public class LatencyHistogram implements org.apache.flink.metrics.Histogram {
    --- End diff --
    
    This class has actually little to do with latency. It's just a wrapper for a DescriptiveStatistics
that we happen to use for measuring latency, as such i would rename the class/fields, and
move it out of the latency namespace.


---

Mime
View raw message