flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4787: [FLINK-6615][core] simplify FileUtils
Date Fri, 13 Oct 2017 12:52:00 GMT
Github user StephanEwen commented on the issue:

    I think here is an interesting example of why I am often hesitant with cleanup refactorings,
unless there is a pressing need to clean up.
    It is very hard to judge if the cleaned up version is really as robust as the original
code. This change looked correct at a first glance, but the concurrency tests caught a subtle
difference in some runs.


View raw message