flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4801: [FLINK-7812] Log system resources metrics
Date Fri, 13 Oct 2017 10:24:35 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4801
  
    Thanks for this addition. Few comments:
    
      - Please try to follow the common (though not enforced) code style when it comes to
empty lines between class declarations, fields, methods, etc.
    
      - What is the license of the new dependency? Can you send a link so we can verify that?
    
      - If possible, let's shade that dependency, avoid increasing the dependency footprint.
    
      - Can we harmonize the config keys between the memory logger and the new system metrics?


---

Mime
View raw message