flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hustfxj <...@git.apache.org>
Subject [GitHub] flink pull request #4813: [FLINK-7821] [table] Deprecate Table.limit() and r...
Date Thu, 12 Oct 2017 11:08:13 GMT
Github user hustfxj commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4813#discussion_r144257631
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/validation/SortValidationTest.scala
---
    @@ -27,10 +27,26 @@ import org.junit._
     class SortValidationTest extends TableTestBase {
    --- End diff --
    
    It had better add the following two validation tests:
    ```
     ds.orderBy('a.asc).offset(10).offset(10)
     ds.orderBy('a.asc).fetch(5)
    ```
    Now` fetch` can only be used after `offset`, maybe the `fetch` be used after `orderBy`.
 `ds.orderBy('a.asc).fetch(5)` is equivalent with `ds.orderBy('a.asc).offset(0)fetch(5)`


---

Mime
View raw message