flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhijiangW <...@git.apache.org>
Subject [GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...
Date Thu, 12 Oct 2017 03:17:20 GMT
Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r144186213
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
    @@ -272,4 +316,53 @@ private void decodeBufferOrEvent(RemoteInputChannel inputChannel,
NettyMessage.B
     			bufferOrEvent.releaseBuffer();
     		}
     	}
    +
    +	private void writeAndFlushNextMessageIfPossible(Channel channel) {
    +		if (channelError.get() != null) {
    +			return;
    +		}
    +
    +		if (channel.isWritable()) {
    --- End diff --
    
    I guess you suggest to separate this PR into some smaller ones?


---

Mime
View raw message