flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 1m2c3t4 <...@git.apache.org>
Subject [GitHub] flink pull request #4784: FLINK-7736: fix some lgtm.com alerts
Date Mon, 09 Oct 2017 09:24:06 GMT
Github user 1m2c3t4 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4784#discussion_r143418356
  
    --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/GroupReduceNode.java
---
    @@ -97,7 +97,7 @@ else if (Optimizer.HINT_LOCAL_STRATEGY_COMBINING_SORT.equals(localStrategy))
{
     		
     		// check if we can work with a grouping (simple reducer), or if we need ordering because
of a group order
     		Ordering groupOrder = null;
    -		if (getOperator() instanceof GroupReduceOperatorBase) {
    +		if (getOperator() != null) {
    --- End diff --
    
    getOperator() has a return type of GroupReduceOperatorBase, so the only problematic case
would be if it returns null


---

Mime
View raw message