flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haohui <...@git.apache.org>
Subject [GitHub] flink pull request #4784: FLINK-7736: fix some lgtm.com alerts
Date Sun, 08 Oct 2017 19:21:17 GMT
Github user haohui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4784#discussion_r143363777
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
---
    @@ -448,7 +448,7 @@ public boolean addTask(Task task) throws SlotNotFoundException, SlotNotActiveExc
     				throw new SlotNotActiveException(task.getJobID(), task.getAllocationId());
     			}
     		} else {
    -			throw new SlotNotFoundException(taskSlot.getAllocationId());
    +			throw new SlotNotFoundException(task.getAllocationId());
    --- End diff --
    
    doesn't seem to be equivalent?


---

Mime
View raw message