flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4358: [FLINK-7068][blob] change BlobService sub-classes ...
Date Wed, 04 Oct 2017 10:31:16 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r142635118
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobKey.java ---
    @@ -83,30 +113,34 @@ public boolean equals(final Object obj) {
     
     		final BlobKey bk = (BlobKey) obj;
     
    -		return Arrays.equals(this.key, bk.key);
    +		return Arrays.equals(this.key, bk.key) && this.type == bk.type;
     	}
     
     	@Override
     	public int hashCode() {
    -		return Arrays.hashCode(this.key);
    +		return Arrays.hashCode(this.key) + this.type.hashCode();
    --- End diff --
    
    ok, I wasn't quite sure and based my code on some examples from the current Flink code.
Apparently, I took the wrong ones.


---

Mime
View raw message