flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...
Date Mon, 02 Oct 2017 21:14:30 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4742#discussion_r142257641
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
    @@ -0,0 +1,206 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client.program.rest;
    +
    +import org.apache.flink.api.common.JobExecutionResult;
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.api.common.JobSubmissionResult;
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.client.program.ClusterClient;
    +import org.apache.flink.client.program.ProgramInvocationException;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.runtime.blob.BlobClient;
    +import org.apache.flink.runtime.blob.BlobKey;
    +import org.apache.flink.runtime.client.JobSubmissionException;
    +import org.apache.flink.runtime.clusterframework.messages.GetClusterStatusResponse;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.runtime.rest.RestClient;
    +import org.apache.flink.runtime.rest.messages.BlobServerPortHeaders;
    +import org.apache.flink.runtime.rest.messages.BlobServerPortResponseBody;
    +import org.apache.flink.runtime.rest.messages.EmptyResponseBody;
    +import org.apache.flink.runtime.rest.messages.JobTerminationHeaders;
    +import org.apache.flink.runtime.rest.messages.JobTerminationMessageParameters;
    +import org.apache.flink.runtime.rest.messages.TerminationModeQueryParameter;
    +import org.apache.flink.runtime.rest.messages.job.JobSubmitHeaders;
    +import org.apache.flink.runtime.rest.messages.job.JobSubmitRequestBody;
    +import org.apache.flink.runtime.rest.messages.job.JobSubmitResponseBody;
    +
    +import java.net.InetSocketAddress;
    +import java.net.URL;
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.concurrent.CompletableFuture;
    +import java.util.concurrent.Executors;
    +
    +/**
    + * A {@link ClusterClient} implementation that communicates via HTTP REST requests.
    + */
    +public class RestClusterClient extends ClusterClient {
    +
    +	private RestClusterClientConfiguration configuration;
    +	private final RestClient restEndpoint;
    +
    +	public RestClusterClient(Configuration config) throws Exception {
    +		this(config, RestClusterClientConfiguration.fromConfiguration(config));
    +	}
    +
    +	public RestClusterClient(Configuration config, RestClusterClientConfiguration configuration)
throws Exception {
    +		super(config);
    +		this.configuration = configuration;
    +		this.restEndpoint = new RestClient(configuration.getRestEndpointConfiguration(), Executors.newFixedThreadPool(4));
    +	}
    +
    +	@Override
    +	public void shutdown() {
    +		this.restEndpoint.shutdown(Time.seconds(5));
    --- End diff --
    
    We don't need to call super. The ClusterClient implementation shuts down the HA services/actorSystemLoeader,
which we don't use.


---

Mime
View raw message