flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4358: [FLINK-7068][blob] change BlobService sub-classes ...
Date Mon, 02 Oct 2017 13:42:12 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r142134172
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -375,7 +378,32 @@ public File getFile(BlobKey key) throws IOException {
     	 * 		Thrown if the file retrieval failed.
     	 */
     	@Override
    -	public File getFile(JobID jobId, BlobKey key) throws IOException {
    +	public File getTransientFile(JobID jobId, BlobKey key) throws IOException {
    +		checkNotNull(jobId);
    --- End diff --
    
    What about making the usage of blob keys failsafe by having different types of `BlobKey`.
E.g. `TransientBlobKey` and `PermanentBlobKey`?


---

Mime
View raw message