flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...
Date Mon, 02 Oct 2017 12:15:52 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4742#discussion_r142103754
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java
---
    @@ -0,0 +1,77 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client.program.rest;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.JobManagerOptions;
    +import org.apache.flink.configuration.RestOptions;
    +import org.apache.flink.runtime.rest.RestClientConfiguration;
    +import org.apache.flink.util.ConfigurationException;
    +
    +/**
    + * A configuration object for {@link RestClusterClient}s.
    + */
    +public final class RestClusterClientConfiguration {
    +
    +	private final String blobServerAddress;
    +
    +	private final RestClientConfiguration restEndpointConfiguration;
    +
    +	private final String restServerAddress;
    +
    +	private final int restServerPort;
    +
    +	private RestClusterClientConfiguration(
    +			String blobServerAddress,
    +			RestClientConfiguration endpointConfiguration,
    +			String restServerAddress,
    +			int restServerPort) {
    +		this.blobServerAddress = blobServerAddress;
    +		this.restEndpointConfiguration = endpointConfiguration;
    +		this.restServerAddress = restServerAddress;
    +		this.restServerPort = restServerPort;
    +	}
    +
    +	public String getBlobServerAddress() {
    +		return blobServerAddress;
    +	}
    +
    +	public String getRestServerAddress() {
    +		return restServerAddress;
    +	}
    +
    +	public int getRestServerPort() {
    +		return restServerPort;
    +	}
    +
    +	public RestClientConfiguration getRestEndpointConfiguration() {
    +		return restEndpointConfiguration;
    +	}
    +
    +	public static RestClusterClientConfiguration fromConfiguration(Configuration config)
throws ConfigurationException {
    +		String address = config.getString(JobManagerOptions.ADDRESS);
    +
    +		String serverAddress = config.getString(RestOptions.REST_ADDRESS);
    +		int serverPort = config.getInteger(RestOptions.REST_PORT);
    +
    +		RestClientConfiguration endpointConfiguration = RestClientConfiguration.fromConfiguration(config);
    --- End diff --
    
    Maybe rename to `restClientConfiguration`


---

Mime
View raw message