Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7026A200D0F for ; Fri, 15 Sep 2017 06:41:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6E5311609CE; Fri, 15 Sep 2017 04:41:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B340D1609CD for ; Fri, 15 Sep 2017 06:41:11 +0200 (CEST) Received: (qmail 1284 invoked by uid 500); 15 Sep 2017 04:41:10 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 1271 invoked by uid 99); 15 Sep 2017 04:41:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Sep 2017 04:41:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B6DD3C6F6D for ; Fri, 15 Sep 2017 04:41:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ViF9VxknVgUC for ; Fri, 15 Sep 2017 04:41:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9FF875FC8A for ; Fri, 15 Sep 2017 04:41:08 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BD525E0E4E for ; Fri, 15 Sep 2017 04:41:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C6F0A25386 for ; Fri, 15 Sep 2017 04:41:02 +0000 (UTC) Date: Fri, 15 Sep 2017 04:41:02 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-7627) SingleElementIterable should implement with Serializable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 15 Sep 2017 04:41:12 -0000 [ https://issues.apache.org/jira/browse/FLINK-7627?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1616= 7317#comment-16167317 ]=20 ASF GitHub Bot commented on FLINK-7627: --------------------------------------- GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/4674 [FLINK-7627] [table] SingleElementIterable should implement with Serial= izable =20 ## What is the purpose of the change =20 *This pull request is a bugfix which implements `SingleElementIterable`= with `Serializable`* =20 =20 ## Brief change log =20 - *Implement SingleElementIterable with Serializable* =20 =20 ## Verifying this change =20 This change added tests and can be verified as follows: =20 - *Added test that validates that `SingleElementIterable` can be seri= alized, otherwise exceptions will be throwed* =20 ## Does this pull request potentially affect one of the following parts= : =20 - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(= Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its c= omponents), Checkpointing, Yarn/Mesos, ZooKeeper: (no ) =20 ## Documentation =20 - Does this pull request introduce a new feature? (no) =20 You can merge this pull request into a Git repository by running: $ git pull https://github.com/hequn8128/flink 7627 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4674.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4674 =20 ---- commit b1af2d612265f0727048388fea7695f42ba897cd Author: =E5=86=9B=E9=95=BF Date: 2017-09-15T03:10:49Z [FLINK-7627] [table] SingleElementIterable should implement with Serial= izable ---- > SingleElementIterable should implement with Serializable=20 > --------------------------------------------------------- > > Key: FLINK-7627 > URL: https://issues.apache.org/jira/browse/FLINK-7627 > Project: Flink > Issue Type: Bug > Components: Table API & SQL > Reporter: Hequn Cheng > Assignee: Hequn Cheng > > {{SingleElementIterable}} is used to merge accumulators and it should be = serializable considering that it will be serialized when doing checkpoint. -- This message was sent by Atlassian JIRA (v6.4.14#64029)