Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 734E4200CFD for ; Wed, 6 Sep 2017 12:13:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 71EBD160BCB; Wed, 6 Sep 2017 10:13:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B8B581609ED for ; Wed, 6 Sep 2017 12:13:04 +0200 (CEST) Received: (qmail 67911 invoked by uid 500); 6 Sep 2017 10:13:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 67902 invoked by uid 99); 6 Sep 2017 10:13:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Sep 2017 10:13:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5EB56C224A for ; Wed, 6 Sep 2017 10:13:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VMSFVcggB95M for ; Wed, 6 Sep 2017 10:13:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0A4D161067 for ; Wed, 6 Sep 2017 10:13:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3176EE0ECA for ; Wed, 6 Sep 2017 10:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5140C24157 for ; Wed, 6 Sep 2017 10:13:00 +0000 (UTC) Date: Wed, 6 Sep 2017 10:13:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 06 Sep 2017 10:13:05 -0000 [ https://issues.apache.org/jira/browse/FLINK-7430?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1615= 5137#comment-16155137 ]=20 ASF GitHub Bot commented on FLINK-7430: --------------------------------------- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4650 =20 Code looks good! I think you can merge as soon as travis is green. =20 Excellent, that you added a test. And it's quite concise with the new J= ava 8 magic. =F0=9F=98=83=20 > ContinuousFileReaderOperator swallows exceptions > ------------------------------------------------ > > Key: FLINK-7430 > URL: https://issues.apache.org/jira/browse/FLINK-7430 > Project: Flink > Issue Type: Bug > Components: DataStream API, filesystem-connector > Affects Versions: 1.4.0, 1.3.2 > Environment: - macOS 10.12.6 > - Oracle JDK 1.8.0_144 > - Flink 1.3.2 > Reporter: Peter Ertl > Assignee: Till Rohrmann > Priority: Critical > > The class *ContinuousFileReaderOperator* is swallowing exceptions as the = following example demonstrates: > {code:java} > package org.apache.flink.streaming.examples; > import java.io.File; > import java.io.IOException; > import org.apache.flink.api.common.io.OutputFormat; > import org.apache.flink.configuration.Configuration; > import org.apache.flink.streaming.api.environment.StreamExecutionEnvironm= ent; > public class FormatExceptionSwallowed { > =09public static void main(String[] args) throws Exception { > =09=09final StreamExecutionEnvironment env =3D StreamExecutionEnvironment= .getExecutionEnvironment(); > =09=09File bla =3D File.createTempFile("foo", "baz"); > =09=09try(PrintWriter w =3D new PrintWriter(bla)) { > =09=09=09w.println("one"); > =09=09=09w.println("two"); > =09=09=09w.println("three"); > =09=09} > =09=09env.readTextFile(bla.getCanonicalPath()) > =09=09=09.writeUsingOutputFormat(new OutputFormat() { > =09=09=09=09@Override > =09=09=09=09public void configure(final Configuration parameters) { > =09=09=09=09} > =09=09=09=09@Override > =09=09=09=09public void open(final int taskNumber, final int numTasks) th= rows IOException { > =09=09=09=09} > =09=09=09=09@Override > =09=09=09=09public void writeRecord(final String record) throws IOExcepti= on { > =09=09=09=09=09throw new IllegalArgumentException("bla"); > =09=09=09=09} > =09=09=09=09@Override > =09=09=09=09public void close() throws IOException { > =09=09=09=09} > =09=09=09}); > =09=09env.execute("go"); > =09=09 > =09=09// JOB TERMINATES WITH NO EXCEPTION / ERROR whatsoever ...=20 > =09} > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)