Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 73FCE200D0F for ; Fri, 29 Sep 2017 21:13:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 726BD1609D1; Fri, 29 Sep 2017 19:13:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BA2C71609BC for ; Fri, 29 Sep 2017 21:13:17 +0200 (CEST) Received: (qmail 65942 invoked by uid 500); 29 Sep 2017 19:13:16 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 65933 invoked by uid 99); 29 Sep 2017 19:13:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 19:13:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 749A9C138C for ; Fri, 29 Sep 2017 19:13:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id V2HhVe6V7yNo for ; Fri, 29 Sep 2017 19:13:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id D82885F5FD for ; Fri, 29 Sep 2017 19:13:14 +0000 (UTC) Received: (qmail 65909 invoked by uid 99); 29 Sep 2017 19:13:14 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 19:13:14 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 07081F5AD9; Fri, 29 Sep 2017 19:13:14 +0000 (UTC) From: bowenli86 To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc... Content-Type: text/plain Message-Id: <20170929191314.07081F5AD9@git1-us-west.apache.org> Date: Fri, 29 Sep 2017 19:13:14 +0000 (UTC) archived-at: Fri, 29 Sep 2017 19:13:18 -0000 Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141945843 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -235,14 +240,15 @@ void releaseBuffer() { ByteBuf write(ByteBufAllocator allocator) throws IOException { checkNotNull(buffer, "No buffer instance to serialize."); - int length = 16 + 4 + 1 + 4 + buffer.getSize(); + int length = 16 + 4 + 4 + 1 + 4 + buffer.getSize(); --- End diff -- can you please add a comment here explaining reasons of the math? ---