Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: suez1224 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4585-flink@git.apache.org>
In-Reply-To: <git-pr-4585-flink@git.apache.org>
Subject: [GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...
Content-Type: text/plain
Message-Id: <20170927233631.409BFF5B71@git1-us-west.apache.org>
Date: Wed, 27 Sep 2017 23:36:30 +0000 (UTC)
archived-at: Wed, 27 Sep 2017 23:36:35 -0000

Github user suez1224 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4585#discussion_r141494139
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala ---
    @@ -0,0 +1,158 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.functions.aggfunctions
    +
    +import java.lang.{Iterable => JIterable}
    +import java.util
    +import java.util.function.BiFunction
    +
    +import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation}
    +import org.apache.flink.api.java.typeutils._
    +import org.apache.flink.table.api.dataview.MapView
    +import org.apache.flink.table.dataview.MapViewTypeInfo
    +import org.apache.flink.table.functions.AggregateFunction
    +
    +
    +/** The initial accumulator for Collect aggregate function */
    +class CollectAccumulator[E](var f0:MapView[E, Integer]) {
    +  def this() {
    +    this(null)
    +  }
    +
    +  def canEqual(a: Any) = a.isInstanceOf[CollectAccumulator[E]]
    +
    +  override def equals(that: Any): Boolean =
    --- End diff --
    
    normal scala class still need to, but case class dont need to.


---