Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: sunjincheng121 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4128-flink@git.apache.org>
In-Reply-To: <git-pr-4128-flink@git.apache.org>
Subject: [GitHub] flink pull request #4128: [FLINK-6893][table]Add BIN supported in SQL
Content-Type: text/plain
Message-Id: <20170924001112.EA1BDF17B3@git1-us-west.apache.org>
Date: Sun, 24 Sep 2017 00:11:12 +0000 (UTC)
archived-at: Sun, 24 Sep 2017 00:11:17 -0000

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4128#discussion_r140644236
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala ---
    @@ -33,6 +33,14 @@ object ScalarSqlFunctions {
         OperandTypes.NILADIC,
         SqlFunctionCategory.NUMERIC)
     
    +  val BIN = new SqlFunction(
    +    "BIN",
    +    SqlKind.OTHER_FUNCTION,
    +    ReturnTypes.explicit(SqlTypeName.VARCHAR),
    +    null,
    +    OperandTypes.NUMERIC,
    --- End diff --
    
    Yes, In current code we only support BYTE,SHORT,INTEGER,LONG. If we try to using a FLOAT input we will got the EXCEPTION. 
    If understand you correctly you want define a new operand types checker, just like `tableAPI(ScalarSqlFunction)`, But I in SQL I'd better using CALCITE's default `OperandTypeChecker`. What do you think?


---